Fix usage of this.props without property (fixes #8)

jsx-eslint · Mar 3, 2015 · 7065e1e · 7065e1e
1 parent 10f66c4
commit 7065e1e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/lib/rules/prop-types.js b/lib/rules/prop-types.js
@@ -31,7 +31,7 @@ module.exports = function(context) {
   return {
 
     'MemberExpression': function(node) {
-      if (node.object.type !== 'ThisExpression' || node.property.name !== 'props') {
+      if (node.object.type !== 'ThisExpression' || node.property.name !== 'props' || !node.parent.property) {
         return;
       }
       usedPropTypes.push(node.parent.property.name);

diff --git a/tests/lib/rules/prop-types.js b/tests/lib/rules/prop-types.js
@@ -65,6 +65,17 @@ eslintTester.addRuleTest('lib/rules/prop-types', {
             ecmaFeatures: {
               jsx: true
             }
+        }, {
+            code: '\
+              var Hello = React.createClass({\
+                render: function() {\
+                  var props = this.props;\
+                  return <div>Hello World</div>;\
+                }\
+              });',
+            ecmaFeatures: {
+              jsx: true
+            }
         }
     ],