Really ignore ref in jsx-handler-names (fixes #396)

jsx-eslint · Jan 16, 2016 · 3371be2 · 3371be2
1 parent 4da92df
commit 3371be2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/lib/rules/jsx-handler-names.js b/lib/rules/jsx-handler-names.js
@@ -27,6 +27,10 @@ module.exports = function(context) {
       var propKey = typeof node.name === 'object' ? node.name.name : node.name;
       var propValue = context.getSource(node.value.expression).replace(/^this\./, '');
 
+      if (propKey === 'ref') {
+        return;
+      }
+
       var propIsEventHandler = PROP_EVENT_HANDLER_REGEX.test(propKey);
       var propFnIsNamedCorrectly = EVENT_HANDLER_REGEX.test(propValue);
 

diff --git a/tests/lib/rules/jsx-handler-names.js b/tests/lib/rules/jsx-handler-names.js
@@ -64,6 +64,11 @@ ruleTester.run('jsx-handler-names', rule, {
       '<TestComponent ref={this.handleRef} />'
     ].join('\n'),
     parserOptions: parserOptions
+  }, {
+    code: [
+      '<TestComponent ref={this.somethingRef} />'
+    ].join('\n'),
+    parserOptions: parserOptions
   }],
 
   invalid: [{