Address review feedback

jsx-eslint · Feb 24, 2017 · 3118f4d · 3118f4d
1 parent b36e82d
commit 3118f4d
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/lib/rules/no-invalid-default-props.js b/lib/rules/no-invalid-default-props.js
@@ -73,7 +73,8 @@ module.exports = {
      * @returns {Boolean}       `true` if the node is a defaultProps declaration, `false` if not
      */
     function isDefaultPropsDeclaration(node) {
-      return (getPropertyName(node) === 'defaultProps' || getPropertyName(node) === 'getDefaultProps');
+      var propName = getPropertyName(node);
+      return (propName === 'defaultProps' || propName === 'getDefaultProps');
     }
 
     /**
@@ -424,7 +425,8 @@ module.exports = {
 
         // e.g.:
         // MyComponent.propTypes.baz = React.PropTypes.string;
-        if (node.parent.type === 'MemberExpression' && node.parent.parent.type === 'AssignmentExpression') {
+        if (node.parent.type === 'MemberExpression' && node.parent.parent &&
+          node.parent.parent.type === 'AssignmentExpression') {
 
           if (isPropType) {
             addPropTypesToComponent(component, [{
@@ -520,8 +522,9 @@ module.exports = {
           return;
         }
 
-        var isPropType = getPropertyName(node) === 'propTypes';
-        var isDefaultProp = getPropertyName(node) === 'defaultProps' || getPropertyName(node) === 'getDefaultProps';
+        var propName = getPropertyName(node);
+        var isPropType = propName === 'propTypes';
+        var isDefaultProp = propName === 'defaultProps' || propName === 'getDefaultProps';
 
         if (!isPropType && !isDefaultProp) {
           return;