Only reporting up to once per file for jsx-filename-extension

jsx-eslint · Jul 23, 2016 · 0f4ec75 · 0f4ec75
1 parent f9ea195
commit 0f4ec75
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 5 deletions.
diff --git a/lib/rules/jsx-filename-extension.js b/lib/rules/jsx-filename-extension.js
@@ -25,18 +25,24 @@ module.exports = function(context) {
     return context.options[0] && context.options[0].extensions || DEFAULTS.extensions;
   }
 
+  var invalidExtension;
+  var invalidNode;
+
   // --------------------------------------------------------------------------
   // Public
   // --------------------------------------------------------------------------
 
   return {
-
     JSXElement: function(node) {
       var filename = context.getFilename();
       if (filename === '<text>') {
         return;
       }
 
+      if (invalidNode) {
+        return;
+      }
+
       var allowedExtensions = getExtensionsConfig();
       var isAllowedExtension = allowedExtensions.some(function (extension) {
         return filename.slice(-extension.length) === extension;
@@ -46,11 +52,18 @@ module.exports = function(context) {
         return;
       }
 
-      var extension = path.extname(filename);
+      invalidNode = node;
+      invalidExtension = path.extname(filename);
+    },
+
+    'Program:exit': function() {
+      if (!invalidNode) {
+        return;
+      }
 
       context.report({
-        node: node,
-        message: 'JSX not allowed in files with extension \'' + extension + '\''
+        node: invalidNode,
+        message: 'JSX not allowed in files with extension \'' + invalidExtension + '\''
       });
     }
   };

diff --git a/tests/lib/rules/jsx-filename-extension.js b/tests/lib/rules/jsx-filename-extension.js
@@ -22,7 +22,7 @@ var parserOptions = {
 // Code Snippets
 // ------------------------------------------------------------------------------
 
-var withJSX = 'module.exports = function MyComponent() { return <div />; }';
+var withJSX = 'module.exports = function MyComponent() { return <div>\n<div />\n</div>; }';
 var withoutJSX = 'module.exports = {}';
 
 // ------------------------------------------------------------------------------