Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support eslint v4. #267

Merged
merged 1 commit into from
Jun 15, 2017
Merged

Support eslint v4. #267

merged 1 commit into from
Jun 15, 2017

Conversation

beefancohen
Copy link
Contributor

@beefancohen beefancohen commented Jun 14, 2017 •
edited
Loading

do we still want v2? Fixes #266

@beefancohen beefancohen requested a review from ljharb June 14, 2017 19:28
ljharb
ljharb approved these changes Jun 14, 2017
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for now - but I think the next breaking change should probably drop v2.

We should wait awhile before dropping v3.

@ljharb ljharb mentioned this pull request Jun 14, 2017
Closed
6 tasks
@coveralls
Copy link

coveralls commented Jun 14, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 99.576% when pulling cbf1c91 on eslint4 into 7dbcfb1 on master.

@beefancohen beefancohen mentioned this pull request Jun 15, 2017
Closed
@beefancohen
Copy link
Contributor Author

sounds good, filed ticket #268 to take care of that

@beefancohen beefancohen merged commit 6076fe5 into master Jun 15, 2017
@ljharb ljharb deleted the eslint4 branch June 15, 2017 03:30
@popomore
Copy link

When will be the next release?

@ljharb
Copy link
Member

ljharb commented Jun 23, 2017

https://github.com/evcohen/eslint-plugin-jsx-a11y/issues/269

@renovate renovate bot mentioned this pull request Jun 27, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@beefancohen @coveralls @popomore @ljharb