[New] interactive-supports-focus: add basic suggestions
#1023
+87
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add basic support for ESlint rule suggestions for the `interactive-supports-focus` for tabIndex values when elements are interactive but do not have implicit focusable browser behaviour. These are intentionally not auto-fix but simply optional suggestions to help developers resolve their issue. Fixes jsx-eslint#952 See also jsx-eslint#951
lb-
force-pushed
the
feature/952-interactive-supports-focus-tab-index-suggestion
branch
from
118498e
to
46e4203
Compare
|
Checking all tests pass & fixing if there are issues. After that I will mark as ready for review. |
|
Ready for review. |
lb-
force-pushed
the
feature/952-interactive-supports-focus-tab-index-suggestion
branch
from
46e4203
to
fc028b4
Compare
ljharb
approved these changes
Oct 26, 2024
ljharb
force-pushed
the
feature/952-interactive-supports-focus-tab-index-suggestion
branch
from
fc028b4
to
068608b
Compare
ljharb
changed the title
interactive-supports-focusinteractive-supports-focus: add basic suggestions
lb-
deleted the
feature/952-interactive-supports-focus-tab-index-suggestion
branch
|
Thank you for reviewing. @ljharb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic support for ESlint rule suggestions for the
interactive-supports-focusfor tabIndex values when elements are interactive but do not have implicit focusable browser behaviour. These are intentionally not auto-fix but simply optional suggestions to help developers resolve their issue.Fixes #952
See also #951
Implementation as per ESlint documentation https://eslint.org/docs/latest/extend/custom-rules#providing-suggestions
Tests added as per ESlint documentation https://eslint.org/docs/latest/integrate/nodejs-api#testing-suggestions
Screenshots of editor suggestions (npm link testing)
Before
After