Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] label-has-associated-control: add additional test cases #1021

Merged

Conversation

lb-
Copy link
Contributor

@lb- lb- commented Oct 22, 2024

- Add test cases for non-nested labels with custom controlComponents
- Fix small typo in mayContainChildComponent util
- See jsx-eslint#962
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lb-

This comment was marked as resolved.

@ljharb

This comment was marked as resolved.

@ljharb ljharb force-pushed the fix/962-label-has-associated-control-regression branch from 8588495 to 30d2318 Compare October 25, 2024 13:07
@ljharb ljharb changed the title [tests] Add additional test cases label-has-associated-control [Tests] label-has-associated-control: add additional test cases Oct 25, 2024
@ljharb ljharb merged commit 30d2318 into jsx-eslint:main Oct 25, 2024
112 checks passed
@lb- lb- deleted the fix/962-label-has-associated-control-regression branch October 25, 2024 23:51
@lb-
Copy link
Contributor Author

lb- commented Oct 25, 2024

Thanks for reviewing and merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

label-has-associated-control regression
3 participants