-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added skin tone option #38
Conversation
- Default no skin tone - Added environment variable to change skin tone (0, 1, 2 ,3, 4) - Added `shift` modifier to copy emoji without skin tone
What happens if a skin tone doesn't exist? Does it fall back to the neutral tone? |
@jsumners Do you mean when you set a skin tone value higher than 4? It will fallback to the neutral tone. |
So if a user has set that they prefer some alternative tone, and the emoji they are choosing doesn't support it, what happens? Can you paste a gif of such a search? |
@jsumners That is what this line is for: It will check if the emoji has skin tone support. |
@jsumners Here is the gif, I hope this answers your question 😄 Currently |
Thank you for the gif; it answers my question clearly.
I know. They are working on a restructuring on the library to follow Unicode releases. It's a difficult problem to tackle. I used up a whole day on it a while back and got basically nowhere (https://twitter.com/jsumners79/status/1211105577188970497). I may get back to it soon 🤷♂ . |
Co-Authored-By: James Sumners <james@sumners.email>
@jsumners If emojilib does the major update, it seems it will have a lot of breaking changes, feel free to tag me and if I have the time I will be happy to implement them. I went through the emojilib PR and unicode-emoji-json yesterday and it seems doable 🤔 I applied your suggested changed 🎉 |
There seems to be an error in one of the travis builds that are not related to the changes 🤔 |
@jsumners Anything you want me to change? Just let me know 😄 |
No. I just need to get around to dealing with it. I want to add in some GitHub Actions (maybe). |
shift
modifier to copy emoji without skin tonefixes #31
This was my first time working on an Alfred workflow 😅 but it was a lot of fun. I am open for feedback.
First credits to https://github.com/muan/mojibar for inspiration how to add skin tone to an emoji.
Also there are a lot of emoji that should support skin tone but the
emojilib
is a little out of date it seems. Hopefully it will get updated soon.I also didn't know if I should add skin tone to Copy code
:+1:
, I couldn't find any information if there is any spec for this or if every app implements this in their own format.For now I used an environment variable
skin_tone
, but a good next improvement would be adding a new Alfred command to change skin tone.