Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add summary field to publication #129

Merged
merged 1 commit into from
Jul 29, 2014
Merged

Add summary field to publication #129

merged 1 commit into from
Jul 29, 2014

Conversation

brianchung808
Copy link
Contributor

No description provided.

@DonDebonair
Copy link
Member

For the record: fixes #126
@thomasdavis hasn't responded yet to the original issue, so lets wait for him to chime in.

@brianchung808
Copy link
Contributor Author

Right, I got a little ahead of myself here

On Mon, Jul 28, 2014 at 7:15 AM, Daan Debie notifications@github.com
wrote:

For the record: fixes #126

@thomasdavis hasn't responded yet to the original issue, so lets wait for him to chime in.

Reply to this email directly or view it on GitHub:
#129 (comment)

@DonDebonair
Copy link
Member

That's no problem! It's great that you're contributing :) I was just stating why I couldn't merge it immediately, although I personally like this change ;)

@brianchung808
Copy link
Contributor Author

Right I understand! 👍 Was just a bit bored last night and decided to do something with my life

thomasdavis added a commit that referenced this pull request Jul 29, 2014
@thomasdavis thomasdavis merged commit 7bde1b9 into jsonresume:master Jul 29, 2014
@thomasdavis
Copy link
Member

Good work guys

@brianchung808 brianchung808 deleted the publication-summary branch July 29, 2014 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants