-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Social url/handle separation #6
Comments
i would suggest This allows for both handle referencing, linking, and API integration |
Adding a bunch of keys like that is not nice. But I agree that you will indeed run into problems. This would be more of my liking.
However, what would be the canonical form for new profile types? Or we could call all of them handle, but that would make the icq num improbable.
Going back to the example:
|
I think
When people use "twitter.com" instead of "twitter", I'm hoping themes will push certain names to become standard. |
I get the idea of using the phrase pk, I really do, but for most social networks there is a distinct identification difference between numerical id, which never changes, and handle, as well as url, my suggestion is to just call that the id as it is more normally understandable |
@jayzalowitz : I'm not sure what you're saying.
|
I don't think there's a use for including a numerical, technical id (like the |
I distinctly disagree, on the nonchanging,stable id front. As someone who has just gotten done building a service around social information and job candidate, I can tell you it is of incredible importance to have both proper linking and programmatic + perm. access to reach out for more information. The best example is tools can be built to keep a resume up to date using these profile ids, and with how portable this is supposed to be that would mean people never really having to update a real resume again. That being said, I agree that userID > pk for multiple reasons |
But what are you saying? Aside from userId (for handles etc.) and url, should we add the technical id as well? I think people should update the userIds in their resume.json, if they change handles etc. |
Yes, It is a really big deal for me to make sure there is a technical id in There are no changes in the fbid... twitterid.. for example they stay the My understanding, which may be wrong, is that twitter teats the id as the Think thats not important? What about a tool that tracks social media |
I pointed this out somewhere else, but many Facebook users do not have usernames, so their URL uses their ID instead. In addition, many LinkedIn users do not have usernames, but instead only have ID's (internal to LinkedIn) and unique URLs for public consumption. There are other services out there that try to give all their users usernames, but as it turns out, usernames are not enforced across their userbase. These might be edge cases, so maybe they shouldn't dictate the default schema label, but there should definitely be a fallback at minimum for people who don't have usernames. |
Also, has "handle" become a universal term now? Is that preferred over "usernames"? So correct me if I understand, but the current choices are:
|
The |
I changed it to include another choice "primaryKey" - also added "id". |
I honestly feel like userid or id makes more sense than pk, thats just me. On Thu, Jul 10, 2014 at 1:05 PM, Ryan Shea notifications@github.com wrote:
|
@jayzalowitz, I'm with you on this one. Even seeing it with the definition, it is the least intuitive. Let's get rid of it. -1 for pk |
I agree, I'm not a fan of pk. Just including that in the list of choices so other people joining the conversation have context. |
That makes sense. Nit: For the sake of sanity, please keep comments rolling forward rather than editing old ones (unless it's within moments of posting). |
Experimenting with a new label called "Decision Needed", this issue has it applied. It means we will be passing something through in the very near future. |
I vote for any of these: "username", "userId" |
+1 for either of those two too, @dandydev |
Also, #71 deals with social media as well, and as I said there: I think we should enforce that either username/userId is provided or url and optionally both. |
Well, username is so common and standard, why even discuss odd alternatives such as |
Still the choice between |
Yes, these two are actually interchangeable, at least in common parlance. I think we can be happy with both of them ;) |
I vote for Link There is a real need in some of the apps I have personally built in the Take it from me, a UserId as described in the sentence above is present in On Fri, Jul 11, 2014 at 5:58 AM, Daan Debie notifications@github.com
|
Eeeehm, I think we're talking about I still think a "technical id" should not be included. Adoption will actually be hampered if people have to lookup this number to complete their jsonresume.
I'm sorry if I don't just "take things" from people on the internet :)
Baseless assumptions as far as I'm concerned. |
Great points everybody, this is a tricky issue. As far as I can tell we might be moving towards something that looks like this, correct me if I'm wrong. {
"profiles": [{
"name": "twitter",
"username": "neutralthoughts"
}, {
"name": "facebook",
"url": "https://www.facebook.com/1231453342"
}
]
} Where |
Let's also add an example of the "both" scenario, so it becomes something like this: {
"profiles": [
{
"name": "twitter",
"username": "neutralthoughts"
},
{
"name": "facebook",
"url": "https://www.facebook.com/1231453342"
},
{
"name": "soundcloud",
"url": "https://soundcloud.com/dandymusicnl",
"username": "dandymusicnl"
},
]
} |
Is there a reason for the both scenario? Otherwise the validator should just make sure one or the other exist and throw errors otherwise "You can't specify a username and url" It's sort of annoying that themes might sometimes get different values for twitter. Sometimes they can show the username, otherwise they will have to infer the username or just show a "Twitter" link |
I was under the assumption we would allow either or both. I don't see a reason why we shouldn't allow someone to put in both their |
Yeah I guess it doesn't affect implementations so much. |
It's usually just redundant information, anyway. And I agree with @opensourcegrrrl that you can just fall back to the "old-school" approach and change one line in your resume when you have changed your Twitter handle etc. I don't think we should have technical, numerical IDs in the resume which are platform-dependent, internal properties of the specific site that are out of our control. Adding URLs in addition (which usually just consist of |
Not every social network provides clear usernames, that why we opted to include an url. I think the discussion is mostly about allowing both for a social network entry, of only allowing one of two. |
Oh, trust me, the url users will submit will not normalize to the username I will never implement this standard unless both username and link are On Sat, Jul 12, 2014 at 9:25 AM, Daan Debie notifications@github.com
|
Please Jay, could you keep the discussions civil? This kind of muscle flexing is not helping at all. That said, as I mentioned earlier, my proposal would be to include them both (optionally) for each social network entry. Require at least one of two, and optionally allow two. So we agree on that. |
Agreed @dandydev. @mwaclawek I would say it is very important to have a URL option OR a numeric ID option. The reason is that many people on LinkedIn, Facebook and other social networks don't have usernames. If a LinkedIn user hasn't picked a username yet, then the URL is the only way to uniquely identify him/her (in a publicly crawl-able way). If a Facebook user hasn't picked a username yet, then the userId and the URL are the only other ways to uniquely identify him/her (they map to each other, where the URL is just If you don't have a URL option, say good bye to supporting LinkedIn, Facebook and other social networks that don't have required usernames. |
And as said, even for social networks that do have clear usernames, such as Twitter, it can be useful/convenient for the user to add the url to his/her profile as well, just to make life easier for template designers. |
Ah, well in the case of twitter, every user has a URL with the same structure taken from the username, so I wouldn't say prepending "https://twitter.com/" is really a problem for template designers. In addition, if it's optional to have a URL, then the template designer would have to support the case for which only a username is provided anyway, so no work is saved. |
Also true. In any case, I think we all agree on |
I think both being included should absolutely be allowed. I wouldn't recommend people populate both fields but I see no benefit in marking the inclusion of both as invalid. SoundCloud is an interesting example because the username does not necessarily map to the URL :O. |
I'm a little lost, why is url not sufficient to cater for user id's? Understandably database indexing wouldn't be as great, but they can infer id's and do their own hacks to make it searchable. |
I believe we were mostly discussing the merits of including a URL option. We simply touched on the idea of user id's. |
{
"profiles": [
{
"name": "twitter",
"username": "neutralthoughts"
},
{
"name": "facebook",
"url": "https://www.facebook.com/1231453342"
},
{
"name": "soundcloud",
"url": "https://soundcloud.com/dandymusicnl",
"username": "dandymusicnl"
},
]
} Good work guys, let's lock down as above. Label applied for PR Needed |
Wait, I don't want to throw a wrench in things, but is "name" the right field label? Would "type" be more appropriate? Only reason I say this is I could imagine people getting confused by "name" and thinking it means the name of person's profile that is being referenced. I know you wouldn't do this, but it could follow logically that either of these could be possible, when iterating through profiles:
Vocalized: "This profile's username is 'neutralthoughts'. It's name is 'twitter'."
Vocalized: "This profile's username is 'neutralthoughts'. It is of type 'twitter' and the name is 'Thomas Davis'.'" Just a thought. |
Agreed, how about On Wed, Jul 16, 2014 at 8:19 PM, Ryan Shea notifications@github.com wrote:
Thomas Davis VP of Tech - Earbits - http://earbits.com |
+1 for |
I realise that might not be entirely accurate for stuff like Skype, but I still think we should roll with it. |
I like |
Alright, lock in |
A bit late, and for the record, +1 for 'network', as in social network.
|
Gj everybody |
Take it from me, unless you have a handle/id (ex FBid)/standardurl setup its going to lead to issues.
The text was updated successfully, but these errors were encountered: