-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a photo to the bio section #29
Comments
Agreed. Some templates might choose to use gravatar for photos, though the specification could contain an alternative field |
+1 |
+1 for optional. |
1 similar comment
+1 for optional. |
Need need some suggestions for the field name.
|
+1 profilePicture -1 for avatar, mugshot, and selfie |
Rationale: If I use a picture of myself, it is not an avatar. Mugshot and selfie reduce the level of professionalism, and are not as easily understood by multiple language backgrounds/cultures. |
In #80 "pictureUrl" is used, but I think that's superfluous. As far as I know, there's not other way to provide a picture in a JSON document, than specifying an URL to a picture (aside maybe from a base64 encoded data-url?). So the best options in my opinion are "profilePicture" or just "picture". |
I'm sad to see no consensus on selfie =( My vote goes to On Thu, Jul 10, 2014 at 5:25 PM, Daan Debie notifications@github.com
Thomas Davis VP of Tech - Earbits - http://earbits.com |
Experimenting with a new label called "Decision Needed", this issue has it applied. It means we will be passing something through in the very near future. |
Optional, of course. But we don't have marked optional and required fields yet, anyway, right? |
The only case where Note: Specs in general are not casual; content based on specs has more flexibility in that regard. |
I cannot think of more |
Can't think of such an instance, either. Many people will not even have a single picture, and I've never seen a resume with two pictures. That should be fine. |
Okay, I think picture will suffice for now. Last comments end in 30mins then I will mark this as ready. The
|
I do think we should choose between |
Sure, we will do another PR at a later date that corrects all the types. On Sat, Jul 12, 2014 at 7:57 PM, Daan Debie notifications@github.com
Thomas Davis VP of Tech - Earbits - http://earbits.com |
Is this still working? (seems so) #80 |
I think we can close this as #80 fixes this. |
As much as it said that physical appearances shouldn't influence a resume, I believe the choice should be left to the user whether or not he wants to use a photo in his resume.
The text was updated successfully, but these errors were encountered: