Further travis tweaks #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Ping @erayd. :) NB Test failures are unrelated, and should be fixed in a separate PR - the failures are just code style due to php-cs-fixer not being pinned. |
erayd
approved these changes
Feb 17, 2020
|
Thanks @GrahamCampbell :-). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we've pinned HHVM to 3.18, and the tests are passing, we should probably take it out of allowed failures now.
Nightly was failing to install dependencies (because, quite rightly, people have marked their code as not working on PHP 8 yet). We can instruct composer to ignore PHP version requirements.
No interaction mode is already enabled due to travis setting an env variable that enforces it.