Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed PHPDoc of Validator::validate() method #587

Merged
merged 1 commit into from
Sep 6, 2019
Merged

Fixed PHPDoc of Validator::validate() method #587

merged 1 commit into from
Sep 6, 2019

Conversation

lyrixx
Copy link
Contributor

@lyrixx lyrixx commented Sep 6, 2019

There are no BaseConstraint::validate(), so PHPDoc can not be inherited

There are no BaseConstraint::validate(), so PHPDoc can not be inherited
Copy link
Contributor

@erayd erayd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :-)

@erayd erayd merged commit 2fa9c72 into jsonrainbow:master Sep 6, 2019
@lyrixx lyrixx deleted the patch-1 branch September 6, 2019 12:18
erayd pushed a commit to erayd/json-schema that referenced this pull request Sep 25, 2019
@erayd erayd mentioned this pull request Sep 25, 2019
erayd added a commit that referenced this pull request Sep 25, 2019
## Backported PRs
 * #559 ArraysTest for array items with enum validation
 * #567 Don't run checks which assume a defined instance against undefined
 * #575 Tests on PHP 7.3
 * #587 Fixed PHPDoc of Validator::validate() method
 * #583 Fix travis PHP 5.4 and 5.5 config

## Additional PRs (5.x.x only)
These PRs are only applicable to the 5.x.x branch, and have been merged individually.
 * #589 Update validate-json to use spl_autoload_register

## Skipped PRs
 * #464 marc-mabe/php-enum versions (dependency not present in 5.x.x)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants