Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the JSON Schema Test Suite to version 2.0.0 #582

Closed
wants to merge 1 commit into from
Closed

Update the JSON Schema Test Suite to version 2.0.0 #582

wants to merge 1 commit into from

Conversation

niconoe-
Copy link
Contributor

@niconoe- niconoe- commented Aug 8, 2019

Update the JSON Schema Test Suite to version 2.0.0 to fetch test suites on Draft 06 and Draft 07.
Updated validation on draft 04 since changes have been done on the test suites.

Regarding some discussions on #581 I wanted to have access to the official test-suite for draft 07. This is possible by upgrading the JSON-Schema-Test-Suite in version 2.0.0, on which Draft 04 has been upgraded too.

I required to upgrade some snippet and make evolved some tests to make pass the Draft 04 validation.

…es on Draft 06 and Draft 07. Updated validation on draft 04 since changes have been done on the test suites.
@DannyvdSluijs
Copy link
Collaborator

@niconoe- thanks for your effort on pushing the draft-7 support in this repo. In an attempt to cleanup this repo we are trying to filter the issues and see which ones might be closed. A quick scan of this PR shows this is a nice improvement by itself. The project was a bit on a halt due to time constraints of the contributors. I'm currently helping out reviving the project, initially with some triage of issues and pull requests.

I guess doe the the PR being rather old commenting on the PR seems impossible (error: Failed to create comment: No head repository for pull request with id: 305626591) nor is there history of any executed GitHub action. And additionally some commits where done causing conflicts on this PR. Would you be available for updating the PR in an attempt to get it ready for merging?

If you're not available to do so that is still okay I can understand that time has changed and so has employment or project needs. Just let us know and we can take it up ourselves and archive this PR.

@niconoe-
Copy link
Contributor Author

Hey!

Thanks for giving feedbacks on this ☺️. I’m currently on holidays but I’ll be back the next week. I’ll try to update the PR and solve the conflicts if I can. I’ll probably need some time to recall about this 5 y.o. PR 😅 but I’ll do my best to help you integrate it.

Thanks again and take care!

@niconoe-
Copy link
Contributor Author

@DannyvdSluijs I'm closing this PR as actually, the issue was I removed this repository long time ago, that's why you missed the original commits.

I created a new PR with the exact same changes, available at #714 . You can take a look at it and merge it if you are ok.

I will also rework on the #581 topic as you'll get the same error.

Thanks a lot for continuing to maintain!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants