Enhancement: Implicitly enable no_unused_imports fixer #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
force-pushed
the
fix/unused-import
branch
from
bf3d2e4
to
78a8a9f
Compare
localheinz
changed the title
localheinz
force-pushed
the
fix/unused-import
branch
from
b8edb39
to
4f6d01c
Compare
localheinz
changed the title
localheinz
force-pushed
the
fix/unused-import
branch
from
e123c28
to
113dbf0
Compare
localheinz
commented
Dec 30, 2017
| @@ -15,7 +15,6 @@ $config | |||
| 'array_syntax' => array('syntax' => 'long'), | |||
| 'binary_operator_spaces' => false, | |||
| 'concat_space' => array('spacing' => 'one'), | |||
| 'no_unused_imports' => false, | |||
There was a problem hiding this comment.
Since no_unused_imports is enabled as part of the @Symfony rule set, we implicitly enable it by removing this rule here.
erayd
approved these changes
Dec 31, 2017
|
Thank you, @bighappyface and @erayd! |
erayd
pushed a commit
to erayd/json-schema
that referenced
this pull request
Feb 14, 2018
Enhancement: Implicitly enable no_unused_imports fixer
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
no_unused_importsfixercomposer style-fix