Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #46. Add support for draft v4 minProperties and maxProperties. #47

Merged
merged 3 commits into from
Jun 10, 2013

Conversation

mchiocca
Copy link
Contributor

@mchiocca mchiocca commented Jun 6, 2013

Addresses issue #46. Implements support for minProperties and maxProperties per the draft v4 specification. Removed tests for these attributes from the list of draft v4 tests that are to be skipped so that they are included when running the draft v4 test suite.

@justinrainbow Looks like my request includes your last two commits. Probably because I did a git merge instead of a git rebase. I hope that's not a problem. Please consider merging this request since it implements important functionality and closes out an issue. Thanks!

@mchiocca
Copy link
Contributor Author

mchiocca commented Jun 6, 2013

@justinrainbow Looks like there are still issues running PHP Analyzer. Travis failed without even running the unit tests. Can you check the Travis logs? I don't understand what happened. It has something to do with Composer being out of date and GitHub authentication credentials. Strange.

@justinrainbow
Copy link
Collaborator

Looks like the GitHub downloads were just rate limited during that run. I re-ran the Travis build and all the tests passed. I think the PHP Scrutinizer configs should be all set now, too. I have an inspection running right now for the master branch, just waiting for it to finish to know for sure.

@mchiocca
Copy link
Contributor Author

Hello. Thanks for looking into the Travis/Scrutinizer issues that occurred with this pull request. Glad the tests passed. How did the Scrutinizer run go? Just wondering if you encountered some of the same issues that I did, such as Scrutinizer timing out or otherwise failing when building PHP dependencies. Hopefully all went well so you'll be able to merge this request. Thanks again!

@justinrainbow
Copy link
Collaborator

Scrutinizer did fail again, but it doesn't look like it failed because of this PR. I've been able to run the checks locally without any issue. This is good to merge and I've just disabled Scrutinizer for the time being.

justinrainbow added a commit that referenced this pull request Jun 10, 2013
Fix #46. Add support for draft v4 minProperties and maxProperties.
@justinrainbow justinrainbow merged commit 3ec2db5 into jsonrainbow:master Jun 10, 2013
@jasj
Copy link

jasj commented Jul 12, 2014

the minProperties doesnt work for me, could any one tell me the reason! thanks

this is the field:

"products" : {"type" : "object", "minProperties": 1,"required": true}

hakre pushed a commit to hakre/json-schema that referenced this pull request Mar 26, 2015
Fix jsonrainbow#46. Add support for draft v4 minProperties and maxProperties.
@shmax shmax mentioned this pull request Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants