[BUGFIX] Tweak phpdocumentor dependency to avoid install conflicts #421

erayd · 2017-05-03T23:23:32Z

What

Change phpdocumentor/phpdocumentor require-dev dependency from ~2 to ^2.7.

Why

Resolves a dependency conflict when installing in dev mode (issue require-dev conflict on php-5.6, 7.0 & 7.1 #420).

shmax · 2017-05-03T23:46:40Z

LGTM

bighappyface

+1

…w#421)

* Split $objectDefinition into $schema and $properties (#411) Object validation attempts to use a single variable to store both the object definition, and its properties. This causes validation to be incomplete where "properties" is not set, but "additionalProperties" is. This commit fixes both bugs in issue #353. * Issue-414: Allow The Option of T or space for Date time. (#415) * Testcase for minProperties with properties defined (#416) + Fix Test * Tweak phpdocumentor dependency to avoid install conflicts (#421) * [BUGFIX] Cast empty schema arrays to object (#409) * Cast root to object * Use function_exists to allow polyfill compatibility * Move array->object conversion to SchemaConstraint & SchemaStorage Fixes issue #408 * fix bug when applying defaults for array items when the schema is for (#405) all items and add support for minItems when applying defaults * [BUGFIX] Split "uri" format into "uri" & "uri-reference", fix meta-schema bug (#419) * Split "uri" format into "uri" and "uri-reference" * Correct format for id & $ref in draft-03/04 meta-schemas See json-schema-org/JSON-Schema-Test-Suite#177 (comment)

chocopowwwa · 2017-05-18T03:25:58Z

I'm still having the issue, it breaks on phpdocumentor 2.9.0, here's my steps to reproduce the issue.
Latest commit 9225c96

git clone https://github.com/justinrainbow/json-schema.git
git checkout origin/6.0.0-dev
composer install

to solve the issue, change phpdocumentor/phpdocumentor require-dev dependency from ^2.7 to ^2.9

but didn't pass the test :|

erayd · 2017-05-18T03:39:45Z

@chocopowwwa That's really weird - this problem is definitely solved on Travis (see here).

Which PHP version are you using?

Can you please confirm the commit hash of origin/6.0.0-dev that you are using to test?

chocopowwwa · 2017-05-18T04:25:06Z

Hi, here's my details:
( Sorry i put the wrong commit hash up there )

Commit Hash:

git rev-parse HEAD
2d404b8

PHP 7.1.5 (cli) (built: May 9 2017 16:55:02) ( NTS )
Copyright (c) 1997-2017 The PHP Group
Zend Engine v3.1.0, Copyright (c) 1998-2017 Zend Technologies
with Xdebug v2.5.3, Copyright (c) 2002-2017, by Derick Rethans

Composer version 1.4.2 2017-05-17 08:17:52

$ composer install
  Problem 1
    - Conclusion: don't install phpdocumentor/phpdocumentor v2.9.0
    - phpdocumentor/phpdocumentor v2.7.0 requires phpdocumentor/fileset ~1.0 -> satisfiable by phpdocumentor/fileset[1.0.0].
    - phpdocumentor/phpdocumentor v2.7.1 requires phpdocumentor/fileset ~1.0 -> satisfiable by phpdocumentor/fileset[1.0.0].
    - phpdocumentor/phpdocumentor v2.8.0 requires phpdocumentor/fileset ~1.0 -> satisfiable by phpdocumentor/fileset[1.0.0].
    - phpdocumentor/phpdocumentor v2.8.1 requires phpdocumentor/fileset ~1.0 -> satisfiable by phpdocumentor/fileset[1.0.0].
    - phpdocumentor/phpdocumentor v2.8.2 requires phpdocumentor/fileset ~1.0 -> satisfiable by phpdocumentor/fileset[1.0.0].
    - phpdocumentor/phpdocumentor v2.8.3 requires phpdocumentor/fileset ~1.0 -> satisfiable by phpdocumentor/fileset[1.0.0].
    - phpdocumentor/phpdocumentor v2.8.4 requires phpdocumentor/fileset ~1.0 -> satisfiable by phpdocumentor/fileset[1.0.0].
    - phpdocumentor/phpdocumentor v2.8.5 requires phpdocumentor/fileset ~1.0 -> satisfiable by phpdocumentor/fileset[1.0.0].
    - Conclusion: don't install phpdocumentor/fileset 1.0.0|install phpdocumentor/phpdocumentor v2.9.0
    - Installation request for phpdocumentor/phpdocumentor ^2.7 -> satisfiable by phpdocumentor/phpdocumentor[v2.7.0, v2.7.1, v2.8.0, v2.8.1, v2.8.2, v2.8.3, v2.8.4, v2.8.5, v2.9.0].

chocopowwwa · 2017-05-18T04:27:02Z

ahh okay, turns out i'm using different phpunit version

mine is 5.7.19
tested using PHPUnit 4.8.35 works fine, my bad.

erayd · 2017-05-18T04:27:54Z

That would do it ;-). PHPUnit 5 isn't compatible with PHP 5.3 unfortunately, so this library is stuck with PHPUnit 4.8.

erayd · 2017-05-18T04:31:42Z

Just to clarify, before I assume this is resolved - am I correct in my understanding that you had manually changed the PHPUnit dependency version in composer.json#/require-dev, and the install failure occured only after you had made that change (i.e. doing a normal install with no modifications worked)?

chocopowwwa · 2017-05-18T04:40:34Z

nope, i run phpunit 5 from my composer global
./vendor/bin/phpunit should do the work

the install error caused by phpdocumentor/phpdocumentor : ^2.7 dependency
after i edit manually phpdocumentor/phpdocumentor to ^2.9 the installation works, and also it pass the test

erayd · 2017-05-18T04:43:57Z

OK - so the install problem is still there on your system, when using phpdocumentor/phpdocumentor : ^2.7?

Are you forcing any other package versions?

chocopowwwa · 2017-05-24T10:20:28Z

@erayd
i tested:
-> ^2.7 : error
-> ^2.8 : error
-> ^2.9 : no error

are you able reproduce the issue?

erayd · 2017-05-24T11:04:14Z

@chocopowwwa I have not managed to reproduce this since I fixed it the first time around, either locally on my dev system or on Travis. I'll have another crack at this tomorrow.

In the meantime, any detail you can provide regarding your environment would be extremely helpful - in particular, anything that deviates from defaults.

As a temporary workaround, you can simply remove phpdocumentor completely. This will prevent you from building the API documentation, but nothing else, and the API docs are a complete mess at the moment anyway - sorting the documentation is one of the many things on my to-do list.

erayd · 2017-05-24T21:50:06Z

@chocopowwwa I'm still not able to reproduce this. Could you please run the script below exactly as it appears here, and paste the full output:

php --version
composer --version
cd /tmp
git clone https://github.com/justinrainbow/json-schema.git
cd json-schema
git checkout 6.0.0-dev
grep phpdocumentor composer.json
composer install
rm -rf vendor composer.lock
git checkout 5.x.x
grep phpdocumentor composer.json
composer install

chocopowwwa · 2017-05-25T09:13:02Z

https://gist.github.com/chocopowwwa/8b3fe8cf246039cefdf0fbf91c805003
i'm sorry @erayd its all fine, on 6.0.0-dev but it breaks on origin/6.0.0-dev, that's kinda weird

Tweak phpdocumentor dependency to avoid install conflicts

1cc4a08

This was referenced May 3, 2017

Backports for 5.2.1 #413

Merged

require-dev conflict on php-5.6, 7.0 & 7.1 #420

Closed

bighappyface approved these changes May 4, 2017

View reviewed changes

bighappyface merged commit d7fcdcb into jsonrainbow:6.0.0-dev May 4, 2017

erayd deleted the bugfix-420-phpdocumentor branch May 4, 2017 19:53

erayd added a commit to erayd/json-schema that referenced this pull request May 4, 2017

Tweak phpdocumentor dependency to avoid install conflicts (jsonrainbo…

082e6e9

…w#421)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BUGFIX] Tweak phpdocumentor dependency to avoid install conflicts #421

[BUGFIX] Tweak phpdocumentor dependency to avoid install conflicts #421

erayd commented May 3, 2017

shmax commented May 3, 2017

bighappyface left a comment

chocopowwwa commented May 18, 2017 •

edited

Loading

erayd commented May 18, 2017

chocopowwwa commented May 18, 2017

chocopowwwa commented May 18, 2017

erayd commented May 18, 2017

erayd commented May 18, 2017

chocopowwwa commented May 18, 2017

erayd commented May 18, 2017

chocopowwwa commented May 24, 2017

erayd commented May 24, 2017

erayd commented May 24, 2017

chocopowwwa commented May 25, 2017

[BUGFIX] Tweak phpdocumentor dependency to avoid install conflicts #421

[BUGFIX] Tweak phpdocumentor dependency to avoid install conflicts #421

Conversation

erayd commented May 3, 2017

What

Why

shmax commented May 3, 2017

bighappyface left a comment

Choose a reason for hiding this comment

chocopowwwa commented May 18, 2017 • edited Loading

erayd commented May 18, 2017

chocopowwwa commented May 18, 2017

chocopowwwa commented May 18, 2017

erayd commented May 18, 2017

erayd commented May 18, 2017

chocopowwwa commented May 18, 2017

erayd commented May 18, 2017

chocopowwwa commented May 24, 2017

erayd commented May 24, 2017

erayd commented May 24, 2017

chocopowwwa commented May 25, 2017

chocopowwwa commented May 18, 2017 •

edited

Loading