Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to type coercion #384

Merged
merged 9 commits into from
Mar 21, 2017
Merged

Improvements to type coercion #384

merged 9 commits into from
Mar 21, 2017

Commits on Mar 21, 2017

  1. Improve performance - don't loop over everything if already valid

    @erayd
    erayd committed Mar 21, 2017
    Configuration menu
    Copy the full SHA
    ba33726 View commit details
    Browse the repository at this point in the history

  2. Don't coerce already-valid types (fixes jsonrainbow#379)

    @erayd
    erayd committed Mar 21, 2017
    Configuration menu
    Copy the full SHA
    7f7a2b1 View commit details
    Browse the repository at this point in the history

  3. Add remaining coercion cases & rewrite tests 

     * Add all remaining coercion cases from ajv matrix
 * Rewrite the coercion tests to tidy things up a bit
    @erayd
    erayd committed Mar 21, 2017
    Configuration menu
    Copy the full SHA
    d70c8d6 View commit details
    Browse the repository at this point in the history

  4. Add CHECK_MODE_EARLY_COERCE 

    If set, falls back to the old behavior of coercing to the first
compatible type, regardless of whether another already-valid type might
be available.
    @erayd
    erayd committed Mar 21, 2017
    Configuration menu
    Copy the full SHA
    a775d4d View commit details
    Browse the repository at this point in the history

  5. Add multiple-type test that requires coercion

    @erayd
    erayd committed Mar 21, 2017
    Configuration menu
    Copy the full SHA
    2ea432b View commit details
    Browse the repository at this point in the history

  6. \JSON_PRETTY_PRINT doesn't exist in PHP-5.3, so work around this

    @erayd
    erayd committed Mar 21, 2017
    Configuration menu
    Copy the full SHA
    4ca0541 View commit details
    Browse the repository at this point in the history

  7. Various PR cleanup stuff 

     * Fix whitespace
 * Turn $early into $extraFlags
 * Change "string" to "ABC" in string test
 * Update README.md description of CHECK_MODE_EARLY_COERCE
    @erayd
    erayd committed Mar 21, 2017
    Configuration menu
    Copy the full SHA
    ab0e8ba View commit details
    Browse the repository at this point in the history

  8. Move loop after complex tests definition

    @erayd
    erayd committed Mar 21, 2017
    Configuration menu
    Copy the full SHA
    c8f4b50 View commit details
    Browse the repository at this point in the history

  9. Move test jsonrainbow#39 to grid jsonrainbow#15

    @erayd
    erayd committed Mar 21, 2017
    Configuration menu
    Copy the full SHA
    a21741d View commit details
    Browse the repository at this point in the history