Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConstraintError throws unresolvable InvalidArgumentException #369

Closed
erayd opened this issue Mar 7, 2017 · 5 comments
Closed

ConstraintError throws unresolvable InvalidArgumentException #369

erayd opened this issue Mar 7, 2017 · 5 comments

Comments

@erayd
Copy link
Contributor

erayd commented Mar 7, 2017 •
edited
Loading

ConstraintError needs to either add a use line, or qualify the exception.
erayd added a commit to erayd/json-schema that referenced this issue Mar 7, 2017
@erayd
Add use line for InvalidArgumentException
9f6bd4a 
Fixes issue jsonrainbow#369
@shmax
Copy link
Collaborator

shmax commented Mar 7, 2017

Whoops. Will fix.

@erayd erayd mentioned this issue Mar 7, 2017
Merged
@erayd
Copy link
Contributor Author

erayd commented Mar 7, 2017 •
edited
Loading

@shmax Already done it - see PR #370 :-)

@erayd
Copy link
Contributor Author

erayd commented Mar 7, 2017

Have also added a test for this to #366.

@shmax
Copy link
Collaborator

shmax commented Mar 7, 2017

Lovely, thank you!

bighappyface pushed a commit that referenced this issue Mar 17, 2017
@erayd @bighappyface
Add use line for InvalidArgumentException (#370)
a4da6ba 
Fixes issue #369
@bighappyface
Copy link
Collaborator

Will be official in 6.0.0

@erayd erayd mentioned this issue Mar 17, 2017
Merged
erayd added a commit to erayd/json-schema that referenced this issue Mar 22, 2017
@erayd
Add use line for InvalidArgumentException (jsonrainbow#370)
0bb66d3 
Fixes issue jsonrainbow#369
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@erayd @shmax @bighappyface