Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vanilla esm support and example. #204

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Add vanilla esm support and example. #204

merged 1 commit into from
Oct 11, 2024

Conversation

jsonnull
Copy link
Owner

@jsonnull jsonnull commented Oct 11, 2024

Fixes #180
Fixes #196
Closes #181

@jsonnull jsonnull force-pushed the esm-support branch 7 times, most recently from d84b9ba to f157f67 Compare October 11, 2024 01:54
@jsonnull jsonnull marked this pull request as ready for review October 11, 2024 02:00
@jsonnull jsonnull merged commit 5acadea into main Oct 11, 2024
3 checks passed
@jsonnull jsonnull deleted the esm-support branch October 11, 2024 02:00
@github-actions github-actions bot mentioned this pull request Oct 11, 2024
@mefengl
Copy link

mefengl commented Dec 5, 2024

I may be wrong, but this fix hasn’t been published on npm?

jsonnull added a commit that referenced this pull request Dec 7, 2024
jsonnull added a commit that referenced this pull request Dec 7, 2024
@jsonnull
Copy link
Owner Author

jsonnull commented Dec 7, 2024

Published now in electron-trpc@1.0.0-alpha.0.

Be advised that there will be more breaking changes in the alpha releases as I do a partial rewrite to fix outstanding issues, but this should unblock you if you're having issues using ESM today.

jsonnull added a commit that referenced this pull request Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants