Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add adr for 'object contains' #1486

Merged
merged 1 commit into from
Apr 3, 2024
Merged

add adr for 'object contains' #1486

merged 1 commit into from
Apr 3, 2024

Conversation

gregsdennis
Copy link
Member

@karenetheridge noted that there wasn't an ADR for this, and I agreed there probably should have been.

Relates to #1077 and #1358.

@gregsdennis gregsdennis requested a review from a team February 8, 2024 20:56
@jdesrosiers jdesrosiers mentioned this pull request Feb 12, 2024
Open
@gregsdennis gregsdennis added the agenda For the OCWM agenda label Feb 12, 2024
@gregsdennis gregsdennis mentioned this pull request Feb 12, 2024
Closed
@Relequestual Relequestual self-requested a review February 12, 2024 22:03
Relequestual
Relequestual approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@Relequestual Relequestual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this work. This is a good example of where ADRs will hopefully be useful.

@benjagm benjagm mentioned this pull request Feb 18, 2024
Closed
@gregsdennis gregsdennis removed the agenda For the OCWM agenda label Feb 18, 2024
@gregsdennis
Copy link
Member Author

closing and reopening to trigger PR policy.

@gregsdennis gregsdennis closed this Apr 3, 2024
@gregsdennis gregsdennis reopened this Apr 3, 2024
@gregsdennis gregsdennis merged commit afe902a into main Apr 3, 2024
4 of 5 checks passed
@gregsdennis gregsdennis deleted the gregsdennis/adr-object-contains branch April 3, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdesrosiers jdesrosiers jdesrosiers approved these changes

@Relequestual Relequestual Relequestual approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gregsdennis @jdesrosiers @Relequestual