Add "contains" to keywords that effect "unevaluatedProperties" #1136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you file an issue in the tests repo for this change before closing please? |
Tests have already been written and already reflect this functionality. This was just a correcting an oversight from when the spec was written. json-schema-org/JSON-Schema-Test-Suite#491 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1135
This PR makes the interaction between
containsandunevaluatedPropertiesconsistent with the interaction betweencontainsandunevaluatedItems. This was an oversight from when we changedcontainsto apply to objects as well as arrays.