Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up subSchemas #695

Merged
merged 2 commits into from
Oct 23, 2023
Merged

clean up subSchemas #695

merged 2 commits into from
Oct 23, 2023

Conversation

karenetheridge
Copy link
Member

..as discussed in #692

@karenetheridge karenetheridge requested a review from a team as a code owner October 23, 2023 22:03
jdesrosiers
jdesrosiers approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@jdesrosiers jdesrosiers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes on my implementation.

gregsdennis
gregsdennis approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@gregsdennis gregsdennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes for me as well.

@karenetheridge karenetheridge merged commit cda4281 into main Oct 23, 2023
3 checks passed
@karenetheridge karenetheridge deleted the ether/clean-up-subSchemas branch October 23, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregsdennis gregsdennis gregsdennis approved these changes

@jdesrosiers jdesrosiers jdesrosiers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karenetheridge @jdesrosiers @gregsdennis