Test that uri format scheme is validated for allowed chars #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is simple to implement. scheme = ALPHA *( ALPHA / DIGIT / + / - / . )
ChALkeR
added a commit
to ChALkeR/is-my-json-valid
that referenced
this pull request
Jul 22, 2020
foo,bar:baz is not a valid uri. Refs: json-schema-org/JSON-Schema-Test-Suite#419
ChALkeR
added a commit
to ChALkeR/ajv
that referenced
this pull request
Jul 22, 2020
foo,bar:baz is not a valid uri. Refs: json-schema-org/JSON-Schema-Test-Suite#419
ChALkeR
added a commit
to ChALkeR/ajv-formats
that referenced
this pull request
Jul 22, 2020
foo,bar:baz is not a valid uri. Refs: json-schema-org/JSON-Schema-Test-Suite#419
ChALkeR
added a commit
to ChALkeR/ajv-formats
that referenced
this pull request
Jul 22, 2020
`foo,bar:baz` is not a valid uri. Refs: json-schema-org/JSON-Schema-Test-Suite#419
ChALkeR
added a commit
to ChALkeR/ajv
that referenced
this pull request
Jul 22, 2020
`foo,bar:baz` is not a valid uri. Refs: json-schema-org/JSON-Schema-Test-Suite#419
Julian
approved these changes
Jul 28, 2020
|
lgtm thanks (and you have merge rights in a second)! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is simple to implement.
In optional, together will all the rest invalid
urivalidation.Comma because this is specifically targeting
[a-z0-9+-.]mistype (which can happen if one just copies the chars from the spec in order into a regex), which should be[a-z0-9+\-.], and the only difference is the comma.