Skip to content

Use openAsync in writeAllAsync #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2024
Merged

Use openAsync in writeAllAsync #134

merged 1 commit into from
Jan 20, 2024

Conversation

T45K
Copy link
Contributor

@T45K T45K commented Jan 13, 2024

Problem

Currently, writeAllAsync methods of CsvWriter are using blocking open method even though they're suspend function.

Solution

Using openAsync method instead of open method so that opening file is executed in Dispatchers.IO.

@T45K T45K changed the title Used openAsync in writeAllAsync Use openAsync in writeAllAsync Jan 13, 2024
@doyaaaaaken
Copy link
Collaborator

Thank you! I'll take a look at it over the weekend. 👍

doyaaaaaken
doyaaaaaken approved these changes Jan 20, 2024
View reviewed changes
Copy link
Collaborator

@doyaaaaaken doyaaaaaken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! 🙇

@doyaaaaaken doyaaaaaken merged commit 1ab3b68 into jsoizo:master Jan 20, 2024
@doyaaaaaken
Copy link
Collaborator

Released in version 1.9.3. 🚀
https://github.com/doyaaaaaken/kotlin-csv/releases/tag/1.9.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doyaaaaaken doyaaaaaken doyaaaaaken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@T45K @doyaaaaaken