Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on Django 5.0 #306

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Test on Django 5.0 #306

merged 1 commit into from
Dec 5, 2023

Conversation

adamchainz
Copy link
Collaborator

Repeating the changes from #284 for the newest Django.

Comment on lines +18 to +30
python-version:
- '3.7'
- '3.8'
- '3.9'
- '3.10'
- '3.11'
django:
- '3.2'
- '4.0'
- '4.1'
- '4.2'
- '5.0'
- 'main'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

broke out into one-per-line to reduce future diff noise when adding/removing versions

Comment on lines 32 to 33
- python-version: '3.7'
django: '4.0'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest a follow-up PR to remove 3.7, since it’s EOL. Sound good?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely—I'll take care of that, thank you!

Comment on lines -14 to -15
python-version: ['3.7', '3.8', '3.9', '3.10', '3.11']
django: ['3.2', '4.0', '4.1']
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized this duplicated actions file wasn't updated in the past 😕. Maybe there’s a way to reduce the duplication more.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked for ways to move the matrix into the task but I couldn't find any. It's probably OK to do a significantly reduced set here, anyway

Copy link
Owner

@jsocol jsocol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!

Comment on lines 32 to 33
- python-version: '3.7'
django: '4.0'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely—I'll take care of that, thank you!

Comment on lines -14 to -15
python-version: ['3.7', '3.8', '3.9', '3.10', '3.11']
django: ['3.2', '4.0', '4.1']
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked for ways to move the matrix into the task but I couldn't find any. It's probably OK to do a significantly reduced set here, anyway

@jsocol jsocol merged commit e113045 into jsocol:main Dec 5, 2023
24 checks passed
@adamchainz adamchainz deleted the django_5.0 branch December 5, 2023 23:40
@adamchainz
Copy link
Collaborator Author

reface_1610231641821_692

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants