-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
toLocaleString
is not fully implemented in many environments
#90
Comments
@mikeevstropov can you take a look at https://github.com/andyearnshaw/Intl.js I'll check it out myself, but it might be a couple weeks before I'm able to. |
@darkbluesun @mikeevstropov I've pushed a version of the plugin with a working fallback format function to the Using BrowserStack, all tests pass on IE 9 and 10, and Android 2.3, 4.4, and 6 in various browsers. Well, all tests except for two floating-point rounding errors when using the fallback format function (#93). Please give this version a shot if you have a chance. I need to updated the documentation (may be a few days) before I publish the new version. |
This fixes the behaviour in my app in IE10 👍 |
Thank you for testing @darkbluesun! Pushed a new version to the Ironically, IE11, Edge, and Windows Phone don't need to use the fallback format function, but they show those same floating point rounding errors when using I still need to update the docs before publishing the new version. |
Just published version 2.2.0 with the fallback function. |
Thanks! 😄 |
Number#toLocaleString
is not fully implemented in many environments, including IE10, IE11, Android, and others.The moment duration format plugin should test the functionality of
Number#toLocaleString
before using it. And should employ a fallback version that implements those options used by the plugin.See #68 and #69.
The text was updated successfully, but these errors were encountered: