[WIP] Rework Key Bindings and Key Handling Events #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 12, 2018
Open
Open
I hope to be able to restore this, but right now it conflicts with a whole slew of keybindings in Atom on the Mac.
jsmecham
force-pushed
the
key-bindings-and-events-work
branch
from
713fe60
to
dbaf616
Compare
This was referenced Apr 21, 2018
|
Any updates on this? The error is beginning to get really annoying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of issues surrounding key bindings and handling of key events across platforms (i.e. conflicts with existing shortcuts, lack of bindings depending on platform, etc). This pull request will attempt to solve all of these compatibility issues.