feat: implement support for altnames #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This properly list is used e.g. by `systemd-udevd` to provide other alternative names for predictable interface names. Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/talos
that referenced
this pull request
Dec 16, 2024
At the moment, we don't use/support aliases, but we might in the future. Altnames are filled out by `systemd-udevd`. This PR has two parts: * show aliases & altnames in `LinkStatus` * match links by aliases/altnames when we configure addresses/routes/links This should make a transition to `systemd-udevd` less painful if the previous link name is in `altNames`. Forked rtnetlink for jsimonetti/rtnetlink#241 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/talos
that referenced
this pull request
Dec 16, 2024
At the moment, we don't use/support aliases, but we might in the future. Altnames are filled out by `systemd-udevd`. This PR has two parts: * show aliases & altnames in `LinkStatus` * match links by aliases/altnames when we configure addresses/routes/links This should make a transition to `systemd-udevd` less painful if the previous link name is in `altNames`. Forked rtnetlink for jsimonetti/rtnetlink#241 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
|
LGTM |
smira
added a commit
to smira/talos
that referenced
this pull request
Dec 16, 2024
At the moment, we don't use/support aliases, but we might in the future. Altnames are filled out by `systemd-udevd`. This PR has two parts: * show aliases & altnames in `LinkStatus` * match links by aliases/altnames when we configure addresses/routes/links This should make a transition to `systemd-udevd` less painful if the previous link name is in `altNames`. Forked rtnetlink for jsimonetti/rtnetlink#241 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/talos
that referenced
this pull request
Dec 16, 2024
At the moment, we don't use/support aliases, but we might in the future. Altnames are filled out by `systemd-udevd`. This PR has two parts: * show aliases & altnames in `LinkStatus` * match links by aliases/altnames when we configure addresses/routes/links This should make a transition to `systemd-udevd` less painful if the previous link name is in `altNames`. Forked rtnetlink for jsimonetti/rtnetlink#241 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/talos
that referenced
this pull request
Dec 17, 2024
At the moment, we don't use/support aliases, but we might in the future. Altnames are filled out by `systemd-udevd`. This PR has two parts: * show aliases & altnames in `LinkStatus` * match links by aliases/altnames when we configure addresses/routes/links This should make a transition to `systemd-udevd` less painful if the previous link name is in `altNames`. Forked rtnetlink for jsimonetti/rtnetlink#241 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
smira
added a commit
to smira/talos
that referenced
this pull request
Dec 17, 2024
At the moment, we don't use/support aliases, but we might in the future. Altnames are filled out by `systemd-udevd`. This PR has two parts: * show aliases & altnames in `LinkStatus` * match links by aliases/altnames when we configure addresses/routes/links This should make a transition to `systemd-udevd` less painful if the previous link name is in `altNames`. Forked rtnetlink for jsimonetti/rtnetlink#241 Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com> (cherry picked from commit 284ab11)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This properly list is used e.g. by
systemd-udevdto provide other alternative names for predictable interface names.