Fix focus issues #77
Merged
Fix focus issues #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jsillitoe Any chance this could be merged in this week? |
|
Any news on it? :) It will help me to solve a bug on IE11 |
pashka
approved these changes
Aug 27, 2018
|
Merged. |
|
@jsillitoe Please, could you publish this fix to NPM? |
Yes, that would be much appreciated @jsillitoe ! |
|
Is this published to NPM yet? |
|
Still experiencing this as an issue in IE11, so I think it's still not published to NPM. Workaround for anyone else waiting for that: #90 (comment) |
|
Lots of people have un-done this change in forks... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74
node.setSelectionRangecaused focus jump in Safari and mobile browsers. The solution is to set selection only if the input is in the active (focused) state to not interfere with other inputs.