Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved interoperability with ES6 classes #99

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nathanlepori
Copy link

PR for #98

@nathanlepori
Copy link
Author

Any updates on this?

@dougwilson
Copy link
Contributor

Sorry, it slipped through the cracks. Is it possible to get tests added for this? I can look into adding them too. Ideally es6 classes to make sure we don't break it in the future.

@nathanlepori
Copy link
Author

Sure no problem. Whenever I have some time I will write a couple tests based on the use case that we encountered on our project

@nathanlepori
Copy link
Author

@dougwilson it's done. I could only come up with one test since the change is very small and it's the only case where it broke (i.e. directly extending HttpError). Let me know if I should add something more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants