Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update top sites cookies #182

Merged
merged 1 commit into from
Oct 7, 2024
Merged

Update top sites cookies #182

merged 1 commit into from
Oct 7, 2024

Conversation

blakeembrey
Copy link
Member

@blakeembrey blakeembrey commented Oct 7, 2024

Update to more closely reflect reality. Google was setting two different cookies of the same length which ended up being treated the same in testing, by making them different this more closely reflects reality.

Also added a few more sites to the examples and hard-coded the example.com empty.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0ecf9bd) to head (5c15052).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #182   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          162       162           
  Branches        68        68           
=========================================
  Hits           162       162           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blakeembrey blakeembrey merged commit 0f56c6e into master Oct 7, 2024
8 checks passed
@blakeembrey blakeembrey deleted the be/update-benchmark branch October 7, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants