Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundling and minification back to core #375

Merged
merged 7 commits into from
Jul 28, 2023

Conversation

dmail
Copy link
Member

@dmail dmail commented Jul 28, 2023

No description provided.

@dmail dmail marked this pull request as ready for review July 28, 2023 14:11
@github-actions
Copy link

github-actions bot commented Jul 28, 2023

File size impact

Impact on file sizes when merging bundling_and_minification_back_to_core into main.

dist (+2%)
Files new size new gzip size
dist/jsenv_core.js 664 kB (+21.2 kB / +3%) 149 kB (+5 kB / +3%) ↗️
Unmodified (106) 349 kB (0 B / +0%) 96.3 kB (0 B / +0%) 👻
Total (107) 1 MB (+21.2 kB / +2%) 245 kB (+5 kB / +2%) ↗️
Generated by @jsenv/file-size-impact during file size impact#5693168167 on 8f4f53b

@github-actions
Copy link

github-actions bot commented Jul 28, 2023

Performance impact

Impact on 32 metrics when merging bundling_and_minification_back_to_core into main. Before drawing conclusion, keep in mind performance variability.

package metrics (+0.4%)
Metric Before merge After merge Impact
import duration 0.2 second 0.2 second -0.004 second / -3% ↘️
import memory heap used 5.4 MB 5.4 MB +41.4 kB / +0.8% ↗️
import memory heap total 5.3 MB 5.4 MB +41 kB / +0.8% ↗️
import fs read operations 0 0 👻
npm tarball size 297 kB 302 kB +5.1 kB / +2% ↗️
npm tarball unpacked size 1.4 MB 1.4 MB +21.6 kB / +2% ↗️
npm tarball file count 190 190 👻
dev server metrics (+38%)
Metric Before merge After merge Impact
start duration 0.2 second 0.2 second +0.002 second / +1% ↗️
start memory heap used 5.8 MB 5.8 MB +48.4 kB / +0.8% ↗️
start memory heap total 5.3 MB 22.7 MB +17.3 MB / +326% ↗️
start fs read 0 0 👻
start fs write 0 0 👻
time to app display 1 second 0.9 second -0.07 second / -7% ↘️
serve app memory heap total 25.2 MB 25.2 MB +4.1 kB / +0.02% ↗️
serve app memory heap used 16.4 MB 16.4 MB +38.6 kB / +0.2% ↗️
serve app fs read 0 0 👻
serve app fs write 0 0 👻
time to 2nd app display 0.5 second 0.5 second +0.002 second / +0.3% ↗️
2nd serve memory heap total 1.6 MB 1.8 MB +262 kB / +17% ↗️
2nd serve memory heap used 1.1 MB 1.1 MB +23.7 kB / +2% ↗️
2nd serve fs read 0 0 👻
2nd serve fs write 0 0 👻
build metrics (-0.1%)
Metric Before merge After merge Impact
build duration 1.7 seconds 1.7 seconds 👻
build memory heap used 31.6 MB 31.5 MB -158 kB / -0.5% ↘️
build memory heap total 54.9 MB 54.9 MB +45.1 kB / +0.08% ↗️
number of fs read operation 0 0 👻
number of fs write operation 56 56 👻
test metrics (+1%)
Metric Before merge After merge Impact
test plan duration 6.8 seconds 7 seconds +0.2 second / +2% ↗️
test plan memory heap used 38.5 MB 38.6 MB +91.1 kB / +0.2% ↗️
test plan memory heap total 73.2 MB 74.8 MB +1.6 MB / +2% ↗️
number of fs read operation 0 0 👻
number of fs write operation 40 40 👻
Generated by @jsenv/performance-impact during performance_impact#5693168164 on 8f4f53b

@dmail dmail force-pushed the bundling_and_minification_back_to_core branch from 2148804 to 8f4f53b Compare July 28, 2023 14:40
@dmail dmail merged commit 92e5a30 into main Jul 28, 2023
5 checks passed
@dmail dmail deleted the bundling_and_minification_back_to_core branch July 28, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant