Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Without search cook #374

Merged
merged 131 commits into from
Jul 28, 2023
Merged

Without search cook #374

merged 131 commits into from
Jul 28, 2023

Conversation

dmail
Copy link
Member

@dmail dmail commented Jul 18, 2023

  • Improve and fix autoreload on inline content (like css in js)
  • When a file variation is cooked, also cook the original file
  • Fix several cases where js module fallback was missing or superflous
  • Ensure correct output for code shared between main document and worker(s)
  • Simplify side effect file injection and prevent double injection in worker files

@github-actions
Copy link

github-actions bot commented Jul 18, 2023


Error: Error while trying to collect info after merging without_search_cook into main.

Error: Command failed: git fetch --no-tags --prune origin without_search_cook
fatal: couldn't find remote ref without_search_cook

    at ChildProcess.exithandler (node:child_process:419:12)
    at ChildProcess.emit (node:events:512:28)
    at maybeClose (node:internal/child_process:1098:16)
    at Socket. (node:internal/child_process:456:11)
    at Socket.emit (node:events:512:28)
    at Pipe. (node:net:332:12)

Generated by @jsenv/file-size-impact during file size impact#5692163561 on ab0faf2

@github-actions
Copy link

github-actions bot commented Jul 18, 2023


Error: Error while trying to collect info after merging without_search_cook into main.

Error: Command failed: git fetch --no-tags --prune origin without_search_cook
fatal: couldn't find remote ref without_search_cook

    at ChildProcess.exithandler (node:child_process:419:12)
    at ChildProcess.emit (node:events:512:28)
    at maybeClose (node:internal/child_process:1098:16)
    at Socket. (node:internal/child_process:456:11)
    at Socket.emit (node:events:512:28)
    at Pipe. (node:net:332:12)

Generated by @jsenv/performance-impact during performance_impact#5692163558 on ab0faf2

@dmail dmail marked this pull request as ready for review July 28, 2023 12:54
@dmail dmail merged commit 38ba26a into main Jul 28, 2023
0 of 5 checks passed
@dmail dmail deleted the without_search_cook branch July 28, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant