Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar revival #331

Merged
merged 41 commits into from
Dec 13, 2022
Merged

Toolbar revival #331

merged 41 commits into from
Dec 13, 2022

Conversation

dmail
Copy link
Member

@dmail dmail commented Dec 7, 2022

  • Reconnect toolbar server indicator to websocket
  • Reconnect toolbar autoreload to parentWindow.__reloader__
  • Split core and ui (using preact signals)
  • More consistency in class names and identifiers
  • Few fixes on toolbar, mostly around animations and overlay

@github-actions
Copy link

github-actions bot commented Dec 7, 2022


Error: Error while trying to collect info after merging toolbar_2 into main.

Error: Command failed: git fetch --no-tags --prune origin toolbar_2
fatal: couldn't find remote ref toolbar_2

    at ChildProcess.exithandler (node:child_process:412:12)
    at ChildProcess.emit (node:events:513:28)
    at maybeClose (node:internal/child_process:1091:16)
    at Socket. (node:internal/child_process:449:11)
    at Socket.emit (node:events:513:28)
    at Pipe. (node:net:313:12)

Generated by @jsenv/file-size-impact during file size impact#3685786043 on a034786

@github-actions
Copy link

github-actions bot commented Dec 7, 2022


Error: Error while trying to collect info after merging toolbar_2 into main.

Error: Command failed: git fetch --no-tags --prune origin toolbar_2
fatal: couldn't find remote ref toolbar_2

    at ChildProcess.exithandler (node:child_process:412:12)
    at ChildProcess.emit (node:events:513:28)
    at maybeClose (node:internal/child_process:1091:16)
    at Socket. (node:internal/child_process:449:11)
    at Socket.emit (node:events:513:28)
    at Pipe. (node:net:313:12)

Generated by @jsenv/performance-impact during performance_impact#3685785600 on a034786

@dmail dmail marked this pull request as ready for review December 7, 2022 13:11
@dmail dmail changed the title Toolbar 2 Toolbar revival Dec 8, 2022
@dmail dmail merged commit eead327 into main Dec 13, 2022
@dmail dmail deleted the toolbar_2 branch December 13, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant