Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import meta resolve #325

Merged
merged 24 commits into from
Nov 15, 2022
Merged

Import meta resolve #325

merged 24 commits into from
Nov 15, 2022

Conversation

dmail
Copy link
Member

@dmail dmail commented Nov 15, 2022

Changes

  • Handle import.meta.resolve during dev and build
  • When plugin.init returns false, plugin is ignored
  • [internal] "context.scenarios.dev" renamed "context.dev"
  • [internal] "js_url_specifier" renamed "js_url"
  • [internal] "js_import_export" renamed "js_import"

@github-actions
Copy link

github-actions bot commented Nov 15, 2022


Error: Error while trying to collect info after merging import_meta_resolve into main.

Error: Command failed: git fetch --no-tags --prune origin import_meta_resolve
fatal: couldn't find remote ref import_meta_resolve

    at ChildProcess.exithandler (node:child_process:389:12)
    at ChildProcess.emit (node:events:537:28)
    at maybeClose (node:internal/child_process:1091:16)
    at Socket. (node:internal/child_process:449:11)
    at Socket.emit (node:events:537:28)
    at Pipe. (node:net:747:14)

Generated by @jsenv/file-size-impact during file size impact#3471557006 on 617c7dc

@github-actions
Copy link

github-actions bot commented Nov 15, 2022


Error: Error while trying to collect info after merging import_meta_resolve into main.

Error: Command failed: git fetch --no-tags --prune origin import_meta_resolve
fatal: couldn't find remote ref import_meta_resolve

    at ChildProcess.exithandler (node:child_process:389:12)
    at ChildProcess.emit (node:events:537:28)
    at maybeClose (node:internal/child_process:1091:16)
    at Socket. (node:internal/child_process:449:11)
    at Socket.emit (node:events:537:28)
    at Pipe. (node:net:747:14)

Generated by @jsenv/performance-impact during performance_impact#3471557045 on 617c7dc

@dmail dmail marked this pull request as ready for review November 15, 2022 13:37
@dmail dmail self-assigned this Nov 15, 2022
@dmail dmail merged commit eeefd63 into main Nov 15, 2022
@dmail dmail deleted the import_meta_resolve branch November 15, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant