Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base url #322

Merged
merged 7 commits into from
Nov 4, 2022
Merged

Base url #322

merged 7 commits into from
Nov 4, 2022

Conversation

dmail
Copy link
Member

@dmail dmail commented Nov 4, 2022

No description provided.

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

File size impact

Impact on file sizes when merging base_url into main.

dist (+0.1%)
Files new size new gzip size
dist/main.js 945 kB (+1.7 kB / +0.2%) 198 kB (+260 B / +0.1%) ↗️
Unmodified (110) 409 kB (0 B / +0%) 117 kB (0 B / +0%) 👻
Total (111) 1.4 MB (+1.7 kB / +0.1%) 316 kB (+260 B / +0.08%) ↗️
Generated by @jsenv/file-size-impact during file size impact#3392381643 on 09fe441

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Performance impact

Impact on 14 metrics when merging base_url into main. Before drawing conclusion, keep in mind performance variability.

package size metrics (+0.08%)
Metric Before merge After merge Impact
npm tarball size 520 kB 520 kB +523 B / +0.1% ↗️
npm tarball unpacked size 2.4 MB 2.4 MB +3.2 kB / +0.1% ↗️
npm tarball file count 308 308 👻
dev server metrics (-0.7%)
Metric Before merge After merge Impact
time to start dev server 0.1 second 0.1 second -0.003 second / -3% ↘️
time to display app 0.9 second 0.9 second +0.01 second / +1% ↗️
time to display app second visit 0.3 second 0.3 second -0.001 second / -0.4% ↘️
build metrics (-6%)
Metric Before merge After merge Impact
build duration 0.6 second 0.6 second -0.003 second / -0.5% ↘️
build memory heap used 26.6 MB 26.6 MB -7.3 kB / -0.03% ↘️
number of fs read operation 0 0 👻
number of fs write operation 48 40 -8 / -17% ↘️
test metrics (-0.2%)
Metric Before merge After merge Impact
test plan duration 5.3 seconds 5.2 seconds -0.04 second / -0.8% ↘️
test plan memory heap used 31.7 MB 31.8 MB +106 kB / +0.3% ↗️
number of fs read operation 0 0 👻
number of fs write operation 32 32 👻
Generated by @jsenv/performance-impact during performance_impact#3392381591 on 09fe441

@dmail dmail marked this pull request as ready for review November 4, 2022 09:00
@dmail dmail merged commit d3c9dbe into main Nov 4, 2022
@dmail dmail deleted the base_url branch November 4, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant