Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js minimum and dependencies #3358

Merged
merged 5 commits into from
Jun 13, 2022
Merged

Conversation

domenic
Copy link
Member

@domenic domenic commented Apr 24, 2022

Let's see what CI says...

@domenic
Copy link
Member Author

domenic commented Apr 25, 2022

Minimal repro of Node v18 failures:

"use strict";
const { JSDOM } = require(".");

const dom = new JSDOM(``, { runScripts: "outside-only" });
console.log(Object.getOwnPropertyDescriptor(dom.window, "onhashchange"));
dom.window.onhashchange = () => {};

this throws

TypeError: Cannot redefine property: onhashchange
    at Object.<anonymous> (C:\Users\Domenic\Dropbox\GitHub\jsdom\jsdom\test.js:6:25)
    at Module._compile (node:internal/modules/cjs/loader:1105:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1159:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Module._load (node:internal/modules/cjs/loader:827:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:77:12)
    at node:internal/main/run_main_module:17:47

Does not appear in Node v17.

@domenic
Copy link
Member Author

domenic commented May 4, 2022

Narrowed it down to a specific vm regression, nodejs/node#42962 . Not sure if this is something we can work around...

@fregante
Copy link

That seems to have been fixed in Node 18.2.0

@domenic domenic merged commit 6c1f058 into master Jun 13, 2022
@domenic domenic deleted the update-deps-and-node branch June 13, 2022 02:24
@fregante
Copy link

Yesss 🎉 this hopefully unblocks #3347 😁

@domenic
Copy link
Member Author

domenic commented Jun 13, 2022

Yep, I plan to slowly make my way through the open PR backlog, mostly over weekends...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants