Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(semver): filter out prerelease tags if trying to release #433

Merged
merged 1 commit into from
Jan 31, 2022
Merged

feat(semver): filter out prerelease tags if trying to release #433

merged 1 commit into from
Jan 31, 2022

Conversation

kaoz70
Copy link
Contributor

@kaoz70 kaoz70 commented Jan 25, 2022

This PR makes it possible to get the latest version not from the last tag, but from the last release tag, the problem we were having is that we release a lot of beta versions and when we tried to make a final release it wasn't possible to do it automatically because the last beta tag existed and it would not detect any changes after it.

@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #433 (c508323) into main (3f2c8db) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
+ Coverage   95.03%   95.07%   +0.03%     
==========================================
  Files          23       23              
  Lines         423      426       +3     
  Branches       66       68       +2     
==========================================
+ Hits          402      405       +3     
  Misses         12       12              
  Partials        9        9              
Impacted Files Coverage Δ
...er/src/executors/version/utils/get-last-version.ts 100.00% <100.00%> (ø)
...ges/semver/src/executors/version/utils/try-bump.ts 98.03% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9579086...c508323. Read the comment docs.

Copy link
Member

@edbzn edbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the work! LGTM.

@edbzn edbzn merged commit 377662c into jscutlery:main Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants