Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification type -> classes always empty #2

Closed
pedro-blablagues opened this issue Aug 28, 2020 · 2 comments
Closed

Notification type -> classes always empty #2

pedro-blablagues opened this issue Aug 28, 2020 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@pedro-blablagues
Copy link

pedro-blablagues commented Aug 28, 2020

Hello,
You script is really good! Many thanks for it!
I just find a strange thing: I try to customize the class of the notification using "classes" attribute like textColor, borderColor, etc ...
In my case, class of the notification is still empty and the configuration not working ...
Is it a bug?
It good be also great to add 2 functionnality:

  • a callback when you click a noticiation,
  • make the timer doing a break when the mouse is hover a notification

Many thanks!
Best regards,
Pierre

@jsanahuja jsanahuja added bug Something isn't working enhancement New feature or request labels Aug 28, 2020
@jsanahuja
Copy link
Owner

I just find a strange thing: I try to customize the class of the notification using "classes" attribute like textColor, borderColor, etc ...
In my case, class of the notification is still empty and the configuration not working ...
Is it a bug?

Yes it is. Fixed now in the latest release (1.2.4)

It good be also great to add 2 functionnality:

  • a callback when you click a noticiation,
  • make the timer doing a break when the mouse is hover a notification

I might implement it soon or if you want to can send a pull request

Thanks!

@pedro-blablagues
Copy link
Author

Many thanks!
That's perfect!
Ok for the other points, I'll send pull request.
Best regards,
Pedro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants