Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intro and Basic modules' solutions #1

Merged
merged 4 commits into from
Sep 25, 2024
Merged

Conversation

belk1ng
Copy link
Contributor

@belk1ng belk1ng commented Sep 24, 2024

Added solutions for tasks:

  • sum
  • createApp
  • WeatherApp

Added solution for the first task with formatting curent day and
rendering it.
Added solution for weather task.
@jsru-1
Copy link
Contributor

jsru-1 commented Sep 24, 2024

Спасибо за отправленный пулриквест, теперь @ShGKme должен запустить тесты.

@jsru-1
Copy link
Contributor

jsru-1 commented Sep 24, 2024

Добавляю преподавателя (@ShGKme) для код-ревью.

@jsru-1 jsru-1 requested a review from ShGKme September 24, 2024 18:32
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Принято, но обратите внимание на комментарий

01-basics/10-create-app/script.js Show resolved Hide resolved
@jsru-1 jsru-1 merged commit 8572c83 into js-tasks-ru:master Sep 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants