Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

krds.js.org #9182

Merged
merged 1 commit into from
Aug 6, 2024
Merged

krds.js.org #9182

merged 1 commit into from
Aug 6, 2024

Conversation

lukasjhan
Copy link
Contributor

Hi guys, I'm a member of krds-community which develops South Korean Design system reference implementation. It's basically a react components library. You can check them in krds-community.github.io/krds-react/

Thank you.

@indus indus changed the title feat: add krds.js.org krds.js.org Aug 5, 2024
@indus indus added add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account awaiting CNAME This PR is waiting for the target to add a CNAME file labels Aug 5, 2024
@indus
Copy link
Member

indus commented Aug 5, 2024

I've already added your requested subdomain to JS.ORGs zonefile. But because you are using a workflow to deploy the page, additional steps may be required to make the CNAME work.
FYI: #7853 (comment) / #8532 (comment)

@lukasjhan
Copy link
Contributor Author

lukasjhan commented Aug 5, 2024

@indus Thank you. I followed what the link said. I think it is set properly now.

Could you please check the configuration again :)

@indus indus removed the awaiting CNAME This PR is waiting for the target to add a CNAME file label Aug 6, 2024
@indus
Copy link
Member

indus commented Aug 6, 2024

Welcome https://krds.js.org

@indus indus merged commit 9b85553 into js-org:master Aug 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants