Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acidmod.js.org #9068

Merged
merged 4 commits into from
Jun 5, 2024
Merged

acidmod.js.org #9068

merged 4 commits into from
Jun 5, 2024

Conversation

gvalue-04
Copy link
Contributor

@gvalue-04
Copy link
Contributor Author

This domain is for my Scratch Modification called AcidMod, made in React JS, node JS, and Blockly (also js)

@gvalue-04 gvalue-04 changed the title Update cnames_active.js acidmod.js.org Jun 2, 2024
@gvalue-04 gvalue-04 closed this Jun 2, 2024
@gvalue-04 gvalue-04 reopened this Jun 2, 2024
@gvalue-04
Copy link
Contributor Author

To access the "content" you need to type "acidmod.github.io/studio" to access the actual modified scratch editor. I'm working on coding a homepage now.

@indus indus added the awaiting response This PR is waiting for a response from the requester label Jun 3, 2024
@indus
Copy link
Member

indus commented Jun 3, 2024

@gvalue-04 It looks like it is just a clone of https://turbowarp.org with a "Hello World" added?!? This doesn't look like rasonable content to me.

@gvalue-04
Copy link
Contributor Author

But I have added things such as More Extensions, More Accents, optimization patches, and am currently working on a project “server” to host AcidMod made projects with extensions, because they can’t be uploaded to Scratch.Im currently taking in suggestions from the community members, and adding them if it’s a reasonable suggestion.

@gvalue-04
Copy link
Contributor Author

The homepage is currently being worked on, there is a private repository currently containing the homepage code, which is designed to look like the rest of the editor

@indus
Copy link
Member

indus commented Jun 3, 2024

@MattIPv4 may I ask you for your opinion on this?

@MattIPv4
Copy link
Member

MattIPv4 commented Jun 3, 2024

👀 This reminds me of #7870 and potentially some other requests? All forks of turbowarp or similar.

I think with a homepage that explains what this is, how it differs from turbowarp itself, and how JavaScript developers would use it, I could see this being accepted. Currently, I'm less sure.

@gvalue-04
Copy link
Contributor Author

Alright, I can work on that, I have been working on a homepage for a while, I just set that up to see if the minimal bootstrap CSS worked

@gvalue-04
Copy link
Contributor Author

I have pushed my changes to the homepage

@indus
Copy link
Member

indus commented Jun 4, 2024

I've already added your requested subdomain to JS.ORGs zonefile. But because you are using a workflow to deploy the page, additional steps may be required to make the CNAME work.
FYI: #7853 (comment) / #8532 (comment)

I'll merge after we have "contact". Please keep this PR open.

@gvalue-04
Copy link
Contributor Author

It works!

@indus indus added add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation and removed awaiting response This PR is waiting for a response from the requester labels Jun 5, 2024
@indus
Copy link
Member

indus commented Jun 5, 2024

Welcome https://acidmod.js.org

@indus indus merged commit ce96c85 into js-org:master Jun 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants