Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

biggames.js.org #8886

Merged
merged 1 commit into from
Mar 12, 2024
Merged

biggames.js.org #8886

merged 1 commit into from
Mar 12, 2024

Conversation

jacobhumston
Copy link
Contributor

Requesting biggames.js.org for https://jacobhumston.github.io/biggames.js (https://github.com/jacobhumston/biggames.js/tree/main)

@jacobhumston jacobhumston changed the title Update cnames_active.js biggames.js.org Mar 12, 2024
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

❌ Before we can accept your domain request, you need to configure your GitHub Pages site to use the requested js.org subdomain. Head to your repository settings, locate the Pages settings (under Code and Automation), and enter the js.org subdomain in the custom domain field. 📝

@MattIPv4 MattIPv4 added the awaiting CNAME This PR is waiting for the target to add a CNAME file label Mar 12, 2024
@jacobhumston
Copy link
Contributor Author

Hi there!

❌ Before we can accept your domain request, you need to configure your GitHub Pages site to use the requested js.org subdomain. Head to your repository settings, locate the Pages settings (under Code and Automation), and enter the js.org subdomain in the custom domain field. 📝

Should be fixed now, sorry about that! Note that the cname file is in the docs folder, as that is how I have configured GitHub pages with the publish action.

Screenshot_20240312-013022~2

@jacobhumston jacobhumston requested a review from MattIPv4 March 12, 2024 05:33
@indus indus added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account labels Mar 12, 2024
@indus
Copy link
Member

indus commented Mar 12, 2024

I've already added your requested subdomain to JS.ORGs zonefile. But because you are using a workflow to deploy the page, additional steps may be required to make the CNAME work.
FYI: #7853 (comment) / #8532 (comment)

@jacobhumston
Copy link
Contributor Author

jacobhumston commented Mar 12, 2024

I've already added your requested subdomain to JS.ORGs zonefile. But because you are using a workflow to deploy the page, additional steps may be required to make the CNAME work.
FYI: #7853 (comment) / #8532 (comment)

I followed the steps listed in the comments and now the domain biggames.js.org seems to be working for me. Thank you!

Edit: I noticed that it added a cname file to the root of the branch, that may possibly be the solution to that issue.

@indus indus removed the awaiting CNAME This PR is waiting for the target to add a CNAME file label Mar 12, 2024
@indus
Copy link
Member

indus commented Mar 12, 2024

Welcome https://biggames.js.org

@indus indus merged commit 063330b into js-org:master Mar 12, 2024
1 check passed
@jacobhumston jacobhumston deleted the patch-1 branch March 12, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants