Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

litecanvas.js.org #8863

Merged
merged 1 commit into from
Feb 28, 2024
Merged

litecanvas.js.org #8863

merged 1 commit into from
Feb 28, 2024

Conversation

luizbills
Copy link
Contributor

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/litecanvas/litecanvas.github.io/blob/main/public/index.html

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation labels Feb 27, 2024
@indus indus added the awaiting CNAME This PR is waiting for the target to add a CNAME file label Feb 27, 2024
@indus
Copy link
Member

indus commented Feb 27, 2024

I've already added your requested subdomain to JS.ORGs zonefile. But you have to (re-)add a file named CNAME to your branch with the single line litecanvas.js.org to make it work (Iguess in the public folder FYI: https://help.github.com/articles/configuring-a-publishing-source-for-github-pages)
I'll merge after we have "contact". Please keep this PR open.

@luizbills
Copy link
Contributor Author

luizbills commented Feb 27, 2024

Done! added CNAME to public dir and in the settings:
Screenshot_20240227_084802_Firefox

@luizbills
Copy link
Contributor Author

I noticed a problem with "too many redirects". Any solution?

@indus
Copy link
Member

indus commented Feb 27, 2024 via email

@luizbills
Copy link
Contributor Author

@indus
Copy link
Member

indus commented Feb 27, 2024

Workflows tend to be a bit tricky. I suggest you first remove all the CNAMEs and then follow the steps from those comments #7853 (comment) / #8532 (comment)

@luizbills
Copy link
Contributor Author

Workflows tend to be a bit tricky. I suggest you first remove all the CNAMEs and then follow the steps from those comments #7853 (comment) / #8532 (comment)

Works! Thanks :D

@indus indus removed the awaiting CNAME This PR is waiting for the target to add a CNAME file label Feb 28, 2024
@indus
Copy link
Member

indus commented Feb 28, 2024

Welcome https://litecanvas.js.org

@indus indus merged commit 3956a08 into js-org:master Feb 28, 2024
1 check passed
@luizbills luizbills deleted the patch-1 branch March 16, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants