Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-ck.js.org #8645

Merged
merged 2 commits into from
Nov 17, 2023
Merged

react-ck.js.org #8645

merged 2 commits into from
Nov 17, 2023

Conversation

abelflopes
Copy link
Contributor

React CK / RCK is a React component & utilities library
https://github.com/abelflopes/react-ck

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

❌ Your requested js.org subdomain must be inserted in alphabetical order in the cnames_active.js file before we can process your request. Please fix this. 🔤

@abelflopes
Copy link
Contributor Author

Hi there!

❌ Your requested js.org subdomain must be inserted in alphabetical order in the cnames_active.js file before we can process your request. Please fix this. 🔤

Hi @MattIPv4 - fixed, thank you!

@indus indus removed the invalid label Nov 16, 2023
@indus
Copy link
Member

indus commented Nov 16, 2023

I've already added your requested subdomain to JS.ORGs zonefile. But because you are using a workflow to deploy the page, additional steps may be required to make the CNAME work.
FYI: #7853 (comment) / #8532 (comment)

@indus indus added the awaiting CNAME This PR is waiting for the target to add a CNAME file label Nov 16, 2023
@abelflopes
Copy link
Contributor Author

I've already added your requested subdomain to JS.ORGs zonefile. But because you are using a workflow to deploy the page, additional steps may be required to make the CNAME work. FYI: #7853 (comment) / #8532 (comment)

I've followed the instructions on #8532 (comment) and it seems to be working fine, thank you.

@indus indus added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account and removed awaiting CNAME This PR is waiting for the target to add a CNAME file labels Nov 17, 2023
@indus indus merged commit 1cb30bd into js-org:master Nov 17, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants