-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vento.js.org #8345
vento.js.org #8345
Conversation
kwaa
commented
Jul 1, 2023
- There is reasonable content on the page (see: No Content)
- I have read and accepted the Terms and Conditions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there!
❌ Before we can accept your domain request, you need to create a file named CNAME
in the root of your github pages site (this may not be the root of your repository). 📝
This file should contain a single line with the full js.org domain you are requesting, in this instance vento.js.org
.
I've already added your requested subdomain to JS.ORGs zonefile. But like Matt said the CNAME is missing. As you are using a workflow to deploy the page there may be other steps involved to get the CNAME working. FYI: #7853 (comment) |
@oscarotero Looks like CNAME doesn't work. can you take a look? Perhaps deploying from artifacts is different from the common branching method and needs to be modified in Repo Settings. |
It looks like there is a redirect loop?
This looks to be a similar issue to previous folks we've seen using GitHub's new Pages deployment. Might I suggest you reach out to GitHub support to see what's going on? They appear to have broken something with this new method. Feel free to cc me (mattipv4@js.org). |
@oscarotero Maybe I can modify the current actions to push to the gh-pages branch to avoid this problem? |
I finally got it to work following this comment #7853 (comment) I set the classic deploy option (from branch) and then set again to GitHub action mode. This seems to fix the issue. |