Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-scrolly-telling.js.org #8223

Closed
wants to merge 2 commits into from
Closed

Conversation

GuptaSiddhant
Copy link
Contributor

@GuptaSiddhant GuptaSiddhant commented May 4, 2023

The site will be used as the home page for new React library. The library assets in creating scroll-based animations.

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

❌ Before we can accept your domain request, you need to create a file named CNAME in the root of your github pages site (this may not be the root of your repository). 📝
This file should contain a single line with the full js.org domain you are requesting, in this instance react-scrolly-telling.js.org.

@MattIPv4 MattIPv4 added the awaiting CNAME This PR is waiting for the target to add a CNAME file label May 5, 2023
@GuptaSiddhant
Copy link
Contributor Author

Hi, I moved the CNAME file to public directory which will copied to the root of gh-pages.

Src: https://github.com/GuptaSiddhant/react-scrolly-telling/blob/main/public/CNAME
gh-pages: http://guptasiddhant.github.io/react-scrolly-telling/CNAME

@indus
Copy link
Member

indus commented May 5, 2023

I've already added your requested subdomain to JS.ORGs zonefile, but can't access you page.
As you are using a workflow to deploy the page there may be other steps involved to get the CNAME working. FYI: #7853 (comment)

@indus
Copy link
Member

indus commented May 8, 2023

@GuptaSiddhant Any updates? There is nothing else we can do from our side to fix the problem.

@GuptaSiddhant
Copy link
Contributor Author

Thank you for informing me about this. I will apply the workaround mentioned in the link.

@indus
Copy link
Member

indus commented May 10, 2023

@GuptaSiddhant Any updates? (I don't want to keep PRs open longer then a couple of days to prevent them from piling up.)

@GuptaSiddhant
Copy link
Contributor Author

I’m closing the PR as I’m not able to resolve issue at the moment. I will reopen the PR once I am able to resolve it. Thank you for your continued support and patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting CNAME This PR is waiting for the target to add a CNAME file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants