Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scaling policy endpoint #136

Merged
merged 3 commits into from
Oct 27, 2022
Merged

Conversation

nikita-b
Copy link
Collaborator

I added scaling-policies endpoints:
https://developer.hashicorp.com/nomad/api-docs/scaling-policies#read-scaling-policy

I can add more tests, but we need merge PR with scaling related operations: #131

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2022

Codecov Report

Merging #136 (dce5157) into master (690add1) will decrease coverage by 0.14%.
The diff coverage is 84.00%.

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
- Coverage   90.61%   90.47%   -0.15%     
==========================================
  Files          27       28       +1     
  Lines        1130     1155      +25     
==========================================
+ Hits         1024     1045      +21     
- Misses        106      110       +4     
Impacted Files Coverage Δ
nomad/api/scaling.py 80.00% <80.00%> (ø)
nomad/__init__.py 98.36% <100.00%> (+0.05%) ⬆️
nomad/api/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nikita-b
Copy link
Collaborator Author

@jonathanrcross @jrxFive Could we fix or disable Publish Test PyPi step? CI is broken because of it :(

@jonathanrcross
Copy link
Collaborator

It took me awhile to realize that the "failure" is due to pypa/gh-action-pypi-publish#49. I'll add the push event that should fix this from failing.

@nikita-b
Copy link
Collaborator Author

@jonathanrcross Thanks!

@nikita-b nikita-b merged commit d8a54bd into jrxFive:master Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants