-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using polyglot extension #11
base: master
Are you sure you want to change the base?
Conversation
Nice! I'll review and merge tomorrow. |
I held off on merging because you mentioned the errors. Are you looking into these or should I try? |
65faf70
to
a68e7e4
Compare
@headius my performance speed and response time is horrible. I fixed the spec, something odd with directory name extensions, do I changed it to something mode specific. But if you could test the new gem in one or two scenario, like a docker container or anything without any cached maven artifacts, that would be great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mkristian I can give it a test here but just updating the ruby-maven-libs gem has worked around the Docker problem already. I'm not sure if I'd be able to reproduce the issue even if I tried! I'll push a preview version of the gem and a PR for JRuby to test it! |
Difficult to test on gem install, because the jar-dependencies seems to only install released gems?
|
using the new maven and the new polyglot-ruby to setup the ruby extension
This setup is done inside the maven distribution itself and thus need no extra configuration to use ruby DSL pom.rb or Mavenfile.
Updated the version to follow the base version of the maven distribution itself (3.9.)